Make app keepers public #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #951 +/- ##
==========================================
+ Coverage 59.14% 59.18% +0.03%
==========================================
Files 51 51
Lines 6198 6198
==========================================
+ Hits 3666 3668 +2
+ Misses 2265 2264 -1
+ Partials 267 266 -1
|
Closed
conorpp
pushed a commit
to wormhole-foundation/wasmd
that referenced
this pull request
Feb 1, 2023
* use ecosystem convention for keeper names in app.go * fix linting * Revert variable renaming * Deprecate attribute access helper * Formatting only * Replace usage of deprecated test helper * Address linter report Co-authored-by: faddat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #881
This PR is based on the work from @faddat in PR #882 (💐) with the variable names renaming reverted.
Added deprecation annotation and formatting.
Note to reviewer: please squash and merge