Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename features to availableCapabilities #993

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Rename features to availableCapabilities #993

merged 2 commits into from
Sep 9, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 8, 2022

See #980

To use the same term "capabilities" as there. Not to be mixed with cosmos capabilities module

@alpe alpe requested a review from pinosu September 8, 2022 13:28
@alpe alpe marked this pull request as draft September 8, 2022 13:29
@alpe alpe force-pushed the 980_wasm_capabilities branch from 0413379 to 2e659ae Compare September 8, 2022 13:33
@alpe alpe marked this pull request as ready for review September 8, 2022 13:47
webmaster128
webmaster128 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think cosmwasm_1_1 should be listed as available capability by default now. I suggested adding it to the lists here but I'm not sure of those are all the relevant places. Feel free to ignore if you want to do that separately.

app/app.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper_test.go Outdated Show resolved Hide resolved
@alpe
Copy link
Contributor Author

alpe commented Sep 9, 2022

I think cosmwasm_1_1 should be listed as available capability by default now.

This makes perfect sense! I did this in #988 already which was started and should be merged before this PR. But it would be cleaner here.

@alpe alpe force-pushed the 980_wasm_capabilities branch from 10af3ec to 76082f7 Compare September 9, 2022 06:43
@alpe alpe merged commit 42758d3 into main Sep 9, 2022
@alpe alpe deleted the 980_wasm_capabilities branch September 9, 2022 07:22
@faddat faddat mentioned this pull request Oct 2, 2022
Closed
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
@alpe @Magicloud
Rename features to availableCapabilities (CosmWasm#993)
7c8623e 
* Rename features to availableCapabilities as in wasmvm

* Review feedback
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
@alpe @conorpp
Rename features to availableCapabilities (CosmWasm#993)
8aab70c 
* Rename features to availableCapabilities as in wasmvm

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@pinosu pinosu Awaiting requested review from pinosu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @webmaster128