Upgrade CosmWasm to beta5 #215
Conversation
webmaster128
force-pushed
the
upgrade-to-beta5
branch
from
29791e8 to
1e4cc2c
Compare
| @@ -41,18 +41,30 @@ func (t IBCTimeoutBlock) IsZero() bool { | |||
| return t.Revision == 0 && t.Height == 0 | |||
| } | |||
|
|
|||
| type IBCTimeoutBoth struct { | |||
| Block IBCTimeoutBlock `json:"block"` | |||
| Timestamp uint64 `json:"timestamp_nanos"` // TODO: simplify to just "timestamp" in Rust | |||
There was a problem hiding this comment.
Simpler field name coming with CosmWasm/cosmwasm#902. Timestamps are always nanoseconds in IBC and we have it documented right in the enum case.
There was a problem hiding this comment.
Timestamps are always nanoseconds in IBC and we have it documented right in the enum case.
Let's discuss this in CosmWasm/cosmwasm#902
I wrote much of this code and twice returned seconds there, as there were no helpers, I just took env.block.time + 2000 or such.
There was a problem hiding this comment.
Okay, we can stick to it if helps. No rush here. I just felt it was overly long when writing the glue code.
| @@ -101,6 +101,11 @@ func (vm *VM) AnalyzeCode(checksum Checksum) (*types.AnalysisReport, error) { | |||
| return api.AnalyzeCode(vm.cache, checksum) | |||
| } | |||
|
|
|||
| // GetMetrics some internal metrics for monitoring purposes. | |||
| @@ -41,18 +41,30 @@ func (t IBCTimeoutBlock) IsZero() bool { | |||
| return t.Revision == 0 && t.Height == 0 | |||
| } | |||
|
|
|||
| type IBCTimeoutBoth struct { | |||
| Block IBCTimeoutBlock `json:"block"` | |||
| Timestamp uint64 `json:"timestamp_nanos"` // TODO: simplify to just "timestamp" in Rust | |||
There was a problem hiding this comment.
Timestamps are always nanoseconds in IBC and we have it documented right in the enum case.
Let's discuss this in CosmWasm/cosmwasm#902
I wrote much of this code and twice returned seconds there, as there were no helpers, I just took env.block.time + 2000 or such.
| @@ -41,18 +41,30 @@ func (t IBCTimeoutBlock) IsZero() bool { | |||
| return t.Revision == 0 && t.Height == 0 | |||
| } | |||
|
|
|||
| type IBCTimeoutBoth struct { | |||
| Block IBCTimeoutBlock `json:"block"` | |||
| Timestamp uint64 `json:"timestamp_nanos"` // TODO: simplify to just "timestamp" in Rust | |||
| // See https://golang.org/pkg/time/#Time.UnixNano | ||
| // at least one of timeout_block, timeout_timestamp is required | ||
| TimeoutTimestamp *uint64 `json:"timeout_timestamp,omitempty"` | ||
| Timeout IBCTimeout `json:"timeout"` |
There was a problem hiding this comment.
This line introduces a bug because in cosmwasm-std the IbcPacket still uses the old format with fields timeout_block and timeout_timestamp.
AdmintoWasmMsg::InstantiateWasmMsg::UpdateAdminandWasmMsg::ClearAdmin