-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complexed enzymes as possible catalysts while building sim_data #1088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's great automating out manual changes but this also makes it more important to have a way of easily looking at data produced from sim_data or create intermediate files from raw_data before sim_data as we've talked about before. In this case, seeing all enzymes for each reaction could be helpful for troubleshooting or analysis but we won't see that in the flat files.
Do you know how many reactions are affected by these changes? Is it just the ones you manually changed or a lot more?
Should we also do the same for equilibrium reactions in addition to complexation? Before #1065 we had to add PUTA-CPLXBND to some reactions catalyzed by PUTA-CPLX which would be included in equilibrium.
@@ -0,0 +1,3 @@ | |||
name value units _source _comments | |||
"ppi_concentration" 5e-4 "units.mol/units.L" "multiple sources" | |||
"pH" 7.2 "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move other metabolism parameters from parameters.tsv here or is it better to just stick these in parameters.tsv? Not sure if we want to tradeoff a bunch of parameter files for more distinction between the parameters in them. We could also use comment rows to distinguish groups like metabolism, charging, ppGpp etc parameters in a single parameters.tsv file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh that's a good point. I like the idea of just differentiating between different parameter types within a single file. I can also think of having just two different parameter files - one for parameters that are experimentally measured, and the other for "modeling parameters" like the kinetic objective weight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also think of having just two different parameter files - one for parameters that are experimentally measured, and the other for "modeling parameters" like the kinetic objective weight
That does seem like a good distinction to make
I totally agree with this, this could also be a good undergrad/rotation starter project. I'll post an issue proposing for this.
There are a total of 118 reactions that gets more enzymes associated to it than what the original flat file suggests with this change.
I didn't expect to find any equilibrium proteins acting as enzymes so thanks for letting me know - do you know if this is a rare case or is more common (TFs also having enzymatic activity)? Would it be safe to assume metabolite-bound proteins have the same enzymatic activity? |
Wow quite a bit! I wonder if any of them would help with cases where we have enzymes go to 0 counts. I think I've checked most of those enzymes on EcoCyc and they weren't part of larger complexes but I'd imagine this change makes things more robust!
I would imagine fairly rare but several more cases probably exist. I know AlaS is also supposed to regulate it's own expression as well as act as a synthetase but we don't model it as a TF in the model and the Ala binding is also disabled to make handling it as a synthetase easier.
That is a great question. I feel like binding would change the conformation enough to change kinetics of reactions if not completely remove the ability to catalyze a reaction but it's also probably dependent on each molecule. We can probably assume the same activity for now unless we find an example otherwise. |
That looks super useful! Might be a little overwhelming but much easier than doing things from the command line. There still might be some cases where an exported table format would be preferred but this definitely can make exploring sim_data a lot easier!
Probably. I forget exactly how the enzymes get stored - I think a dict maybe reaction and enzymes. I'd imagine it should pick up on all the differences and hopefully in an easy to read way. |
This PR makes changes to the building of
sim_data.metabolism
such that protein complexes that contain an enzyme as part of the complex always retain the enzymatic activity of the said enzyme. This makes the manual changes made to themetabolic_reactions.tsv
file unnecessary. I also pulled out two hard-coded parameters in theprocess/metabolism.py
file as a flat file of its own.