Added pyenchant/pylint automated spell checking #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #159 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 22 22
Lines 3807 3807
Branches 431 431
=============================================
Hits 3807 3807
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tannermpeterson
previously approved these changes
Apr 8, 2021
.github/workflows/dev-test.yaml
Outdated
| # - name: Install enchant (required for pylint spellchecking) | ||
| # if: matrix.IS_FASTEST_JOB == true | ||
| # run: apt-get install -y enchant | ||
|
|
There was a problem hiding this comment.
Can this commented code be deleted?
tannermpeterson
previously approved these changes
Apr 8, 2021
tannermpeterson
force-pushed
the
pyenchant
branch
from
1fd7d17
to
ae78d60
Compare
jperson
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may need to run
apt-get install -y enchantto install it locally. But it appears to exist already in the github CI environment.Currently, there's no easy way to ignore spellchecking the code that's in the comments, so I'm using sphinx directives (which are ignored). I raised some issues with pylint to see if they're open to me correcting this.
pylint-dev/pylint#4320
pylint-dev/pylint#4319