Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moveall says "No message found" instead of "Several messages have been moved" #137

Closed
Tracked by #138
Aeris1One opened this issue Feb 24, 2023 · 1 comment · Fixed by #143
Closed
Tracked by #138

moveall says "No message found" instead of "Several messages have been moved" #137

Aeris1One opened this issue Feb 24, 2023 · 1 comment · Fixed by #143
Labels
bug Something isn't working

Comments

@Aeris1One
Copy link
Collaborator

After a successful transfer of messages from a channel to another, instead of sending an embed with "Several messages have been moved to [destination channel]", the bot outputs an error message "No message found" and the embed "Moving messages to [destination channel]..." stays while it should have been deleted at the end of the transfer.
@Aeris1One Aeris1One added bug Something isn't working PLUGIN and removed PLUGIN labels Feb 24, 2023
@Aeris1One Aeris1One changed the title messageManager: moveall says "No message found" instead of "Several messages have been moved" moveall says "No message found" instead of "Several messages have been moved" Feb 24, 2023
@Aeris1One Aeris1One moved this to 🆕 Planned in 👻 Gipsy Feb 24, 2023
@Aeris1One
Copy link
Collaborator Author

This is a regression since 1.3, should be fixed before releasing 1.4.

@ascpial ascpial mentioned this issue Feb 26, 2023
Merged
6 tasks
Aeris1One added a commit that referenced this issue Feb 26, 2023
@Aeris1One
🐛 fix: fix "No message found" when only two messages must be moved
6e74e69 
+ some additional checks
Closes #137
@Aeris1One Aeris1One mentioned this issue Feb 26, 2023
Merged
Aeris1One added a commit that referenced this issue Feb 26, 2023
@Aeris1One
🐛 fix: fix "No message found" when only two messages must be moved
48e4fa9 
+ some additional checks
Closes #137
@github-project-automation github-project-automation bot moved this from 🆕 Planned to ✅ Done in 👻 Gipsy Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix #137 Curiosity-org/Gipsy
1 participant
@Aeris1One