Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 More consistent logs across the bot #133

Merged
merged 6 commits into from
Jun 18, 2023
Merged

🔊 More consistent logs across the bot #133

merged 6 commits into from
Jun 18, 2023

Conversation

ascpial
Copy link
Contributor

@ascpial ascpial commented Feb 21, 2023

Cette PR modifie le système de logs actuels avec une uniformisation des sorties et des méthodes d'écriture de logs sur tout le bot.
Chaque plugin dispose de son propre logger à son nom.

Cette PR résout aussi des ordres d'imports et quelques imports inutils.

@ascpial ascpial changed the title 🔊 feat: more consistent logs across the bot 🔊 More consistent logs across the bot Feb 21, 2023
@Aeris1One Aeris1One added the enhancement Request enhancement of an existing feature label Feb 26, 2023
@ascpial ascpial added this to the v1.5 milestone Mar 14, 2023
@ZRunner
Copy link
Contributor

ZRunner commented Jun 16, 2023

Friendly bump, ça en est où ?

@ascpial
Copy link
Contributor Author

ascpial commented Jun 16, 2023

Apparemment il y a des restes de l'ancien système dans permissions, utils/errors.py et utils_timeclass.py et ça devrait être bon.

Avant ça, je vais rebaser sur la dernière version.

@ascpial
Copy link
Contributor Author

ascpial commented Jun 16, 2023

Good to go, pour les deux derniers fichiers, il n'est pas nécessaire de changer le logger puisqu'il s'agit d'un fichier du cœur, il est normal qu'il utilise le logger du bot.

@ascpial ascpial marked this pull request as ready for review June 16, 2023 17:01
@ascpial ascpial requested a review from a team June 17, 2023 20:09
core/logger.py Show resolved Hide resolved
plugins/antikikoo/antikikoo.py Outdated Show resolved Hide resolved
plugins/antikikoo/antikikoo.py Outdated Show resolved Hide resolved
utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Aeris1One Aeris1One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascpial ascpial merged commit 2fab39d into beta Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants