✨ feat: add heartbeat monitoring plugin #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aeris1One
force-pushed
the
monitoring
branch
from
5a7b49f to
7e035da
Compare
Aeris1One
force-pushed
the
monitoring
branch
3 times, most recently
from
c124b75 to
90af567
Compare
Aeris1One
force-pushed
the
monitoring
branch
from
90af567 to
d2e269f
Compare
ZRunner
reviewed
Nov 14, 2023
plugins/monitoring/monitoring.py
Outdated
| if resp.status != 200: | ||
| self.logger.error("Monitoring ping failed with status %s", resp.status) | ||
| return False | ||
| else: |
There was a problem hiding this comment.
"Unnecessary else after return" ou un truc du genre :derp:
Si on peut retirer un niveau d'indentation, je vote pour
There was a problem hiding this comment.
Toutafé je corrige ça
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement UptimeKuma push monitoring