fix issue #50: now handle array with -1 as length and return a null r…

…eply instead of raising an invalid format exception
Cylix · Feb 16, 2017 · c4f4e04 · c4f4e04
2 parents 41a57a6 + f00192e
commit c4f4e04
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/sources/builders/array_builder.cpp b/sources/builders/array_builder.cpp
@@ -45,11 +45,12 @@ array_builder::fetch_array_size(std::string& buffer) {
 
   int64_t size = m_int_builder.get_integer();
   if (size < 0) {
-    __CPP_REDIS_LOG(error, "cpp_redis::builders::array_builder receives invalid array size");
-    throw redis_error("Invalid array size");
+    m_reply.set();
+    m_reply_ready = true;
   }
-  else if (size == 0)
+  else if (size == 0) {
     m_reply_ready = true;
+  }
 
   m_array_size = size;
 

diff --git a/tests/sources/spec/builders/array_builder_spec.cpp b/tests/sources/spec/builders/array_builder_spec.cpp
@@ -141,5 +141,11 @@ TEST(ArrayBuilder, InvalidSize) {
   cpp_redis::builders::array_builder builder;
 
   std::string buffer = "-1\r\n";
-  EXPECT_THROW(builder << buffer, cpp_redis::redis_error);
+  builder << buffer;
+
+  EXPECT_EQ(true, builder.reply_ready());
+  EXPECT_EQ("", buffer);
+
+  auto reply = builder.get_reply();
+  EXPECT_TRUE(reply.is_null());
 }