Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ibcv3 feature for cw-proposal-single contract #318

Merged

Conversation

de-husk
Copy link
Contributor

@de-husk de-husk commented Jun 4, 2022

When we were trying to create a proposal with a create validator transaction, we found out that we dont currently support the stargate field in a CosmosMsg.

I decided to enable the ibc3 feature, which includes the stargate features and the new ibcv3 interchain account stuff.

@de-husk de-husk changed the title [WIP] Enable ibcv3 feature for cw-proposal-single contract Enable ibcv3 feature for cw-proposal-single contract Jun 4, 2022
Copy link

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

contracts/cw-proposal-single/src/tests.rs Show resolved Hide resolved
contracts/cw-proposal-single/Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. Thanks!

Would be nice to test that these new message types can be executed by the core module before we merge this. I have a suspicion that without the dependency there it isn't going to know how to parse these in ExecuteProposalHook.

contracts/cw-proposal-single/src/tests.rs Show resolved Hide resolved
Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for putting this together. Super important for supporting IBC stuff. Glad you caught this before we deployed.

@de-husk de-husk force-pushed the samangan/enable-stargate-feature-for-cosmwasm-std branch from f997552 to bbb965a Compare June 7, 2022 18:41
@0xekez 0xekez merged commit b5f2b08 into DA0-DA0:main Jun 7, 2022
@de-husk de-husk deleted the samangan/enable-stargate-feature-for-cosmwasm-std branch June 9, 2022 01:00
JakeHartnell pushed a commit that referenced this pull request Dec 13, 2023
Migrate contracts to 0.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants