-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ibcv3 feature for cw-proposal-single contract #318
Enable ibcv3 feature for cw-proposal-single contract #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. Thanks!
Would be nice to test that these new message types can be executed by the core module before we merge this. I have a suspicion that without the dependency there it isn't going to know how to parse these in ExecuteProposalHook
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks for putting this together. Super important for supporting IBC stuff. Glad you caught this before we deployed.
f997552
to
bbb965a
Compare
Migrate contracts to 0.15.0
When we were trying to create a proposal with a create validator transaction, we found out that we dont currently support the
stargate
field in a CosmosMsg.I decided to enable the ibc3 feature, which includes the
stargate
features and the new ibcv3 interchain account stuff.