-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cw-admin-factory contract #370
Conversation
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 96.92% 96.94% +0.01%
==========================================
Files 37 39 +2
Lines 8695 8760 +65
==========================================
+ Hits 8428 8492 +64
- Misses 267 268 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! No feedback on the functionality. Would be great to add a test using the mock_env
and etc. functions, but not a big deal if you alternatively want to test this on chain and then link to the transaction or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, shame about multitest but it is what it is. Zeke made some good points to address prior to merge but overall functionality is good!
Need to rebase on main for typescript to work. |
b6ac26f
to
6dcc486
Compare
closes #359