Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_229 #234

Merged
merged 1 commit into from
Aug 27, 2023
Merged

fix_229 #234

merged 1 commit into from
Aug 27, 2023

Conversation

d-chambers
Copy link
Contributor

Description

Fixes the issue described in #229.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #234 (084d6c2) into master (e2cc416) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          75       75           
  Lines        6068     6076    +8     
=======================================
+ Hits         5999     6007    +8     
  Misses         69       69           
Flag Coverage Δ
unittests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dascore/core/coords.py 100.00% <100.00%> (ø)
dascore/examples.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@d-chambers d-chambers merged commit 6c938d3 into master Aug 27, 2023
12 checks passed
@d-chambers d-chambers deleted the fix_229 branch August 27, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant