Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe release #255

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Recipe release #255

merged 5 commits into from
Sep 12, 2023

Conversation

ahmadtourei
Copy link
Collaborator

@ahmadtourei ahmadtourei commented Sep 11, 2023 •
edited
Loading

Description

Fix #254

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers
Copy link
Contributor

Ah, looks like there is a conflict because your branch wasn't based on master. Mind merging master into it or make a new branch based on master?

@ahmadtourei ahmadtourei added the ready_for_review PR is ready for review label Sep 12, 2023
@d-chambers d-chambers merged commit 2d96d75 into master Sep 12, 2023
1 check passed
@d-chambers d-chambers deleted the recipe_release branch September 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-chambers d-chambers d-chambers approved these changes

Assignees
No one assigned
Labels
ready_for_review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recipes side menu missing
2 participants
@ahmadtourei @d-chambers