Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #251 #256

Merged
merged 3 commits into from
Sep 13, 2023
Merged

fix #251 #256

merged 3 commits into from
Sep 13, 2023

Conversation

d-chambers
Copy link
Contributor

Description

This PR address issue #251. It also fixed a performance bug where slicing a DirectorySpool could result in loading patches into memory prematurely.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #256 (78bb4a0) into master (453deee) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files          79       79              
  Lines        6440     6438       -2     
==========================================
- Hits         6380     6378       -2     
  Misses         60       60              
Flag Coverage Δ
unittests 99.06% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dascore/clients/dirspool.py 100.00% <100.00%> (ø)
dascore/core/spool.py 100.00% <100.00%> (ø)

@d-chambers d-chambers merged commit beb6901 into master Sep 13, 2023
12 checks passed
@d-chambers d-chambers deleted the fix_251 branch September 13, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant