Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 refactor #310

Merged
merged 9 commits into from
Dec 15, 2023
Merged

HDF5 refactor #310

merged 9 commits into from
Dec 15, 2023

Conversation

d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Dec 14, 2023

Description

This PR fixes #278 by adding support for the Brady Hotsprings flavor of CF1.7 and implementing the ideas in #290, although the interface is simpler. A consequence is now either pytables or h5py can be used for file io.

Also fixed a small bug with how attrs extracts dimensions from coordinates, and simplified the internals of resource manager.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec2c248) 99.30% compared to head (1bb6090) 99.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   99.30%   99.47%   +0.16%     
==========================================
  Files          86       88       +2     
  Lines        6796     6850      +54     
==========================================
+ Hits         6749     6814      +65     
+ Misses         47       36      -11     
Flag Coverage Δ
unittests 99.47% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers added the IO Work for reading/writing different formats label Dec 15, 2023
@d-chambers d-chambers merged commit c8125f2 into master Dec 15, 2023
15 checks passed
@d-chambers d-chambers deleted the hdf5_refactor branch December 15, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Work for reading/writing different formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brady Hot springs IO Support
1 participant