Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #295 #311

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix #295 #311

merged 3 commits into from
Dec 15, 2023

Conversation

d-chambers
Copy link
Contributor

Description

This PR fixes #295.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers d-chambers added bug Something isn't working spool related to Spool class labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec2c248) 99.30% compared to head (42b69d6) 99.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          86       86           
  Lines        6796     6797    +1     
=======================================
+ Hits         6749     6750    +1     
  Misses         47       47           
Flag Coverage Δ
unittests 99.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 18bae4e into master Dec 15, 2023
13 of 15 checks passed
@d-chambers d-chambers deleted the fix_295 branch December 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spool related to Spool class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Str of empty memory spool raises
1 participant