Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentek format #320

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Sentek format #320

merged 8 commits into from
Dec 21, 2023

Conversation

Shihao-Yuan
Copy link
Collaborator

@Shihao-Yuan Shihao-Yuan commented Dec 20, 2023

Description

Add a new data format for Sentek interrogator.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@Shihao-Yuan Shihao-Yuan added IO Work for reading/writing different formats ready_for_review PR is ready for review labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (910f0eb) 99.50% compared to head (2f6a1bb) 99.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          89       92    +3     
  Lines        7051     7130   +79     
=======================================
+ Hits         7016     7095   +79     
  Misses         35       35           
Flag Coverage Δ
unittests 99.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor

Hey @Shihao-Yuan,

I thought of a way to improve the auto-format detection code we worked on today. Will you take a look, and, if you agree, and if this works well for reading your file archive of Sentek files, click the merge button.

🥳

@Shihao-Yuan Shihao-Yuan merged commit 6d38342 into master Dec 21, 2023
15 checks passed
@d-chambers d-chambers deleted the master-sentek branch December 21, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Work for reading/writing different formats ready_for_review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants