Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dft to be idempotent for already transformed coords #397

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

d-chambers
Copy link
Contributor

Description

closes #395

This PR makes dft idempotent, meaning calling dft on the same dimension twice does nothing. See #395 for motivation and example.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (dea01ab) to head (c626e35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         106      106           
  Lines        8625     8640   +15     
=======================================
+ Hits         8611     8626   +15     
  Misses         14       14           
Flag Coverage Δ
unittests 99.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor Author

also fixes #390

@d-chambers d-chambers merged commit c72907f into master Jun 11, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_395 branch June 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dft should be idempotent
1 participant