Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix febus overlap issue #449

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix febus overlap issue #449

merged 4 commits into from
Oct 29, 2024

Conversation

d-chambers
Copy link
Contributor

Description

The way the overlapping time samples were calculated in the febus file format were off. Moreover, sometimes the percentage overlap in the header was set, but the block rate, temporal sampling, and data shape would indicate there is no overlap. This PR fixes both issues by calculating the number of overlapping samples based on the temporal sampling, block rate, and data shape and ignoring the block overlap attribute which can be wrong.

I also ran into a precision issue with the datetime64 object. One file @jinwar gave me has a temporal sampling rate of 3.33333333e-5. When converted to a timedelta64 this is 33333ns. It then causes some issues in determining the exact end of a file. In this case, the endtime is off by 0.003 seconds for a 5 minute file. Hopefully we can just work around this for now, but we may need to think of a better solution for cases like this in the future.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (3d635c1) to head (48a21b7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         114      114           
  Lines        9184     9191    +7     
=======================================
+ Hits         9170     9177    +7     
  Misses         14       14           
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit b2551d2 into master Oct 29, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_febus_overlap branch October 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant