Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way the overlapping time samples were calculated in the febus file format were off. Moreover, sometimes the percentage overlap in the header was set, but the block rate, temporal sampling, and data shape would indicate there is no overlap. This PR fixes both issues by calculating the number of overlapping samples based on the temporal sampling, block rate, and data shape and ignoring the block overlap attribute which can be wrong.
I also ran into a precision issue with the datetime64 object. One file @jinwar gave me has a temporal sampling rate of 3.33333333e-5. When converted to a timedelta64 this is 33333ns. It then causes some issues in determining the exact end of a file. In this case, the endtime is off by 0.003 seconds for a 5 minute file. Hopefully we can just work around this for now, but we may need to think of a better solution for cases like this in the future.
Checklist
I have (if applicable):