Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in logs does not handle embedded parentheses #57

Closed
sillydan1 opened this issue Dec 6, 2022 · 0 comments
Closed

Links in logs does not handle embedded parentheses #57

sillydan1 opened this issue Dec 6, 2022 · 0 comments
Assignees
@sillydan1
Labels
bug 🐛 error or discrepancy feedback 📣 general feature feedback

Comments

@sillydan1
Copy link
Collaborator

v1.4.0-rc1 feedback

Given for example the markdown-style link: [someText](component:myComponent(foo, bar)) does not work.

Suggested Fix

  • Either modify the current regex to handle this special case, or
  • Use a real proper markdown parser package (might be a bit overkill)
@sillydan1 sillydan1 added bug 🐛 error or discrepancy feedback 📣 general feature feedback labels Dec 6, 2022
@sillydan1 sillydan1 self-assigned this Dec 6, 2022
sillydan1 added a commit that referenced this issue Dec 7, 2022
@sillydan1
fix: log-link regex now handles parentheses in the links
6d70988 
This solves issue #57
@sillydan1 sillydan1 mentioned this issue Dec 7, 2022
Merged
sillydan1 added a commit that referenced this issue Dec 7, 2022
@sillydan1
fix: log-link regex now handles parentheses in the links
ccae65c 
This solves issue #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sillydan1 sillydan1

Labels
bug 🐛 error or discrepancy feedback 📣 general feature feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sillydan1