Dragging tags outside of component fixed #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrke
requested changes
Jul 20, 2020
| @@ -212,6 +215,37 @@ private void initializeShape() { | |||
| textField.requestFocus(); // This needs to be done twice because of reasons | |||
| } | |||
|
|
|||
| //Handle constraints for guards, selects, synchronizations, and updates | |||
| if(getParent() instanceof NailPresentation){ | |||
| if(getParent().localToParent(getBoundsInParent()).getCenterX() > getComponent().widthProperty().doubleValue() - textField.getWidth()) { | |||
There was a problem hiding this comment.
It seems the two cases are very similar, I think there should be a function (or just extract the object that you work on)
somthing like:
if (getParent() instanof NailPresentation) {
o = getParent()
} else {
o = getParent.getParent()
}
if (o.localToParent(...
...
There was a problem hiding this comment.
Definitely, must have missed it as I ran through it
yrke
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the tags for guards, selections, and so on are always snapped to a location inside the component, when they are dragged outside the component