[451,484] Update log4j dependency to 2.x (master) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
reviewed
Jan 7, 2025
|
I cannot run these changes against the full test suite easily. Because I've watched metalnx work with these changes, I think that's a good enough test for this work to be merged. Tested using irods-contrib/metalnx-web#376. |
|
Will update the commit message to include slf4j. |
|
Commit message updated. |
|
#'d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates log4j to 2.x and removes slf4j as a dependency.
Jargon now compiles against the log4j 2 API only. That means Jargon no longer defines a default logging implementation. Users of the library can add log4j-core to their pom.xml file to get an implementation.
Confirmed this works with small test application, but still need to run against full test suite.
Will take out of draft once I've confirmed everything works.