Fix for QMOS not updating lat/lon ranges correctly. #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlberry
suggested changes
Feb 27, 2020
| @@ -797,6 +802,25 @@ namespace Isis { | |||
| configDialog->show(); | |||
| } | |||
|
|
|||
| void MosaicGridTool::onProjectionChanged() { | |||
|
Once I get this in Ethan's hands and finds no issues + a re-review after the docstring change we can merge. |
jessemapel
approved these changes
Feb 27, 2020
krlberry
approved these changes
Feb 27, 2020
AustinSanders
approved these changes
Feb 27, 2020
|
We got Ethan's blessing 👍 |
jessemapel
pushed a commit
to jessemapel/ISIS3
that referenced
this pull request
Mar 1, 2020
* qqqqqqmoooooosssssss * added doc string
jessemapel
added a commit
that referenced
this pull request
Mar 3, 2020
* Fix for QMOS not updating lat/lon ranges correctly. (#3714) * qqqqqqmoooooosssssss * added doc string * Hand ported #3716 from dev to 3.10 * Adds the ability to save and restore a greyscale stretch to/from a Cube (#3717) * Update meta.yaml to rename conda package to isis from isis3 * Initial stretch attempt * Now will write a single stretch with a name and type to the cube * Stretch updated to inherit from Blob, re-loading a saved stretch works but only if Linear right now * Clean up Stretch class * Completely move stretchTypes into stretch class, and some minor cleanup * Fixed combo-box not updating bug and more cleanup * Further cleanup of propagated earlier changes with types and names being removed from unnecessary classes * Removed added unneeded member variables from StretchType * Cleanup StretchTool class * Update enter-text dialogs to drop down selection options * Wrapped some long strings * Initial commit to address most of review comments * Removed buttons in case of RGB stretch and add a 'Color' PvlKeyword to Stretch output Co-authored-by: Stuart Sides <[email protected]> * Pinned opencv * Ported #3713 to ISIS3 * Fixes ddd2isis to support updated uvflat files (#3719) * Fixes ddd2isis to support updated uvflat files * Added history comment * Ticked to 3.11_RC1 * changed kaguyatc2isis outputcube call Co-authored-by: Kelvin Rodriguez <[email protected]> Co-authored-by: Kristin <[email protected]> Co-authored-by: Stuart Sides <[email protected]> Co-authored-by: acpaquette <[email protected]>
jessemapel
pushed a commit
to jessemapel/ISIS3
that referenced
this pull request
Mar 4, 2020
* qqqqqqmoooooosssssss * added doc string
ladoramkershner
added a commit
that referenced
this pull request
Mar 4, 2020
* Fix for QMOS not updating lat/lon ranges correctly. (#3714) * qqqqqqmoooooosssssss * added doc string * Fixes ddd2isis to support updated uvflat files (#3719) * Fixes ddd2isis to support updated uvflat files * Added history comment * prep for 4.0.1 Co-authored-by: Kelvin Rodriguez <[email protected]> Co-authored-by: acpaquette <[email protected]>
jessemapel
pushed a commit
to jessemapel/ISIS3
that referenced
this pull request
Mar 4, 2020
* qqqqqqmoooooosssssss * added doc string
ladoramkershner
added a commit
that referenced
this pull request
Mar 4, 2020
* Fixes ddd2isis to support updated uvflat files (#3719) * Fixes ddd2isis to support updated uvflat files * Added history comment * Fix for QMOS not updating lat/lon ranges correctly. (#3714) * qqqqqqmoooooosssssss * added doc string * Prep for 3.10.1 Co-authored-by: acpaquette <[email protected]> Co-authored-by: Kelvin Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QMOS is broken on lon direction = positivewest on top of ranges being incorrect when new map files are loaded. This should fix the issue as described.
Related Issue
#3573
Motivation and Context
We want the grid tool to work.
How Has This Been Tested?
Manually tested with all the projection files @lwellerastro posted as part of the test. This includes switching between postivewest/east and 180 to 360 domains while messing with options in the grid tool to see if grid still draws correctly. Everything seems to work.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: