updated spiceserver version check to include major version

[Kelvinrr]

Description

Makes sure spiceserver also checks ISIS major version if CHECKVERSION=TRUE.

Even if this gets merged, we need to consider a strategy for updating the spiceserver instance to push this update for users. Right now I am inclined to make updates based on release and therefore wait until the next release to update the server and determine a method for testing a build before making it live that is much cleaner than what I had to do here.

Related Issue

#3725

Motivation and Context

spiceserver does not work for ISIS versioned >= 4.0.0

How Has This Been Tested?

I grabbed a request file that is part of the spiceserver tests and updated the payload's client version number to 4.0.0, repacked it into hex using xxd and ran spiceserver with it as input to make sure it passed the version check.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation change (update to the documentation; no code change)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read and agree to abide by the Code of Conduct
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[jessemapel]

Wow such change

[jessemapel]

Looks good once CI passes

[Kelvinrr]

Test failed because of the temp file, updated the test to use a different tempfile location.

[Kelvinrr]

All tests passed, just needs approval then should be merged.