Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and tested functionality for 'N/A' stats calculation. #3895

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

AustinSanders
Copy link
Contributor

Added and tested functionality for including "N/A" in stats output.

Description

In situations in which there are no valid pixels, stats output skipped a variety of stats types. This led to problems in the alignment of columns when output was combined with images that contained valid pixels.

Related Issue

#3870

Motivation and Context

This allows for columns to be populated with "N/A" in situations in which an image contains only special pixels.

How Has This Been Tested?

Functionality was manually tested on the data included in #3870 issue description. Additionally, "stats" ctests were updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few clean-up comments.

Make sure you add a history comment in stats.xml so that it gets added to the online docs.

isis/src/base/apps/stats/stats.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/stats/stats.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jessemapel jessemapel merged commit 18af914 into DOI-USGS:dev Jun 4, 2020
jessemapel pushed a commit to jessemapel/ISIS3 that referenced this pull request Jun 11, 2020
…#3895)

* Added and tested functionality for 'N/A' stats calculation.

* Added changelog and updated style to conform with isis standards.
jessemapel pushed a commit that referenced this pull request Jun 12, 2020
* Added and tested functionality for 'N/A' stats calculation.

* Added changelog and updated style to conform with isis standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants