-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mappt coordlist functionality #3905
Conversation
This is somewhat tangential but the include guard in mappt.h has |
@acpaquette good catch. Should be fixed now. |
It looks like in campt.xml, all instances of campt got changed to mappt. |
uuuuuuugh this is the most spaghetti PR |
@kaitlyndlee you seem to commenting changes my last commit fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, but it looks like the flatfile output got removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry one more mappt->campt thing. Besides that and Jesse's comment about the missing flatfile output option this looks good to me!
d030204
to
ae04a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me aside from some debug cout statements that were left in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good!
Description
Mappt now has a coordlist option like campt.
Related Issue
#3872
Motivation and Context
This makes mappt more in line with campt and allows users to avoid multiple mappt runs on the same projected image.
How Has This Been Tested?
Tests added and are passing
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: