Moved old ISIS unitTests into core #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinSanders
approved these changes
Mar 11, 2021
jessemapel
commented
Mar 11, 2021
| # Set up a cmake script which will run the executable | ||
| # and then check the results against the truth file. | ||
| set(testScript "${PROJECT_SOURCE_DIR}/cmake/RunUnitTest.cmake") | ||
| set(fullTestPath $<TARGET_FILE:${executableName}>) |
There was a problem hiding this comment.
The location of the test executable changes based on if just core is being built or all of ISIS. This resolves to the proper location regardless of where it ends up.
|
@AustinSanders CI looks good I'm going to go ahead and merge this |
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Jun 7, 2021
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Jun 9, 2021
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Jul 7, 2023
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
acpaquette
pushed a commit
that referenced
this pull request
Oct 2, 2023
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
acpaquette
pushed a commit
that referenced
this pull request
Oct 11, 2023
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
amystamile-usgs
added a commit
that referenced
this pull request
Oct 19, 2023
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (#4352) * Initial core deployment (#4355) * Updated preference files (#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (#4523) * Add Blob to core from base (#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
amystamile-usgs
added a commit
that referenced
this pull request
Oct 30, 2023
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (#4352) * Initial core deployment (#4355) * Updated preference files (#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (#4523) * Add Blob to core from base (#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
amystamile-usgs
pushed a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Aug 16, 2024
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
amystamile-usgs
added a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Aug 16, 2024
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (DOI-USGS#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (DOI-USGS#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (DOI-USGS#4352) * Initial core deployment (DOI-USGS#4355) * Updated preference files (DOI-USGS#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (DOI-USGS#4523) * Add Blob to core from base (DOI-USGS#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (DOI-USGS#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (DOI-USGS#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
amystamile-usgs
pushed a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Aug 16, 2024
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
amystamile-usgs
added a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Aug 16, 2024
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (DOI-USGS#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (DOI-USGS#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (DOI-USGS#4352) * Initial core deployment (DOI-USGS#4355) * Updated preference files (DOI-USGS#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (DOI-USGS#4523) * Add Blob to core from base (DOI-USGS#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (DOI-USGS#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (DOI-USGS#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
amystamile-usgs
pushed a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Sep 18, 2024
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
amystamile-usgs
added a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Sep 18, 2024
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (DOI-USGS#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (DOI-USGS#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (DOI-USGS#4352) * Initial core deployment (DOI-USGS#4355) * Updated preference files (DOI-USGS#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (DOI-USGS#4523) * Add Blob to core from base (DOI-USGS#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (DOI-USGS#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (DOI-USGS#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
amystamile-usgs
pushed a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Sep 20, 2024
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
amystamile-usgs
added a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
Sep 20, 2024
* Added history comment. * Initial move to core * Removed Pvl cmakelists * Removed more cmakelists.txt * Add subdirectory * Fully modularized core * Fully modularized core * replaced PvlEditDialog that was accidentally removed in prev commit * Initial constants unit gtest * Fixed pvl core test config (DOI-USGS#4349) * Fixed pvl core test config * Changed cmake_source to project_source for submodule * Fixed pvl core test config * Changed cmake_source to project_source for submodule * First working swig wrappers * Rebased off of pvl_core * Moved old ISIS unitTests into core (DOI-USGS#4351) * First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build * Finished swig wrapper with some syntax sugar for ease of use in python (DOI-USGS#4352) * Initial core deployment (DOI-USGS#4355) * Updated preference files (DOI-USGS#4354) * Reset main build and created core recipe Forgot meta.yaml Change where the build is pulling from Fixed qt requirement in core recipe Removed complier definition Turn swig build on * Changed pvl recipe url to point to usgsastro * Fixed typo * Removed a chunk of files that made it through the rebase (DOI-USGS#4523) * Add Blob to core from base (DOI-USGS#4525) * Fixed tests * Remove Blob from base * Pvl core Docs (DOI-USGS#4536) * Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change * Blob Swig Wrapper (DOI-USGS#4613) * Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl * Post rebase fixes * Fixed app logging for all call able apps * Moved table reading/writing into core * Fixed missing license identifiers, and leftover merge conflict from rebase * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Removed unnecessary includes to classes outside of core * Removed tempFixtures include in core tests * Updates sources and includes for building * Moves necessary fixtures into core * Enforce that core unit tests use the test preferences * Removed commented Application::Name all * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Updated IException test truth data * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Moved Endian into core * Remove additional 'm' extension for python 3.10 * Set version to 0.0.1 and clamped qt bellow 5.15 * Initial changes for isis pvl python interface * Fixed missed conflict in rebase * Removed prints causing test failures * QPair -> std::pair * removed QT from ArraySubscriptNotInRange * removed QT from Message::Keyword* * Updated MissingDelimiter.cpp and deps * Updated MemoryAllocFailed * compiling updates * PvlSequence updated * Updated table, tablefield, and tablerecord --------- Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Stuart Sides <[email protected]>
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Sep 23, 2024
* First pass at old unitTests * re-removed old files * Slim down and unittest port * installing IsisPreferences * Fixed tests in a full build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all of the old style unit tests into the core and got them passing except for IException because we have commented out the program name part of the print out. I also moved a bunch of things out of the core because they are not require for the PVL classes.
This is a huge PR, but just because it's adding back a bunch of files that were removed. Look specifically at the CMakeLists.txt files and the new RunUnitTest.cmake file (this is copied from isis/cmake).