-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to ingest Kaguya MI MAP V3 Images #4432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few small comments.
Changes look good, waiting on CI to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now actually compiling 🎉
Still looks good to me and CI was clean.
Still needs a changelog entry and then this can be merged |
Gives
mimap2isis
the ability to ingest MI MAP V3 images.Description
Updates the necessary translation files to ingest MI MAP V3 images. Also changes a small portion of logic within mimap2isis to avoid unnecessary code being used to ingest MI MAP labels.
Related Issue
Closes #2067
Motivation and Context
ISIS 5.0.1 Support Sprint 4/12/21
How Has This Been Tested?
New test added and changes checked through existing tests
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: