Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to ingest Kaguya MI MAP V3 Images #4432

Merged
merged 6 commits into from
May 25, 2021

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Apr 30, 2021

Gives mimap2isis the ability to ingest MI MAP V3 images.

Description

Updates the necessary translation files to ingest MI MAP V3 images. Also changes a small portion of logic within mimap2isis to avoid unnecessary code being used to ingest MI MAP labels.

Related Issue

Closes #2067

Motivation and Context

ISIS 5.0.1 Support Sprint 4/12/21

How Has This Been Tested?

New test added and changes checked through existing tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small comments.

isis/src/kaguya/apps/mimap2isis/mimap2isis.cpp Outdated Show resolved Hide resolved
isis/src/kaguya/apps/mimap2isis/mimap2isis.cpp Outdated Show resolved Hide resolved
isis/tests/FunctionalTestsMimap2isis.cpp Outdated Show resolved Hide resolved
isis/tests/FunctionalTestsMimap2isis.cpp Outdated Show resolved Hide resolved
jessemapel
jessemapel previously approved these changes May 24, 2021
@jessemapel
Copy link
Contributor

Changes look good, waiting on CI to merge.

jessemapel
jessemapel previously approved these changes May 24, 2021
Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now actually compiling 🎉

Still looks good to me and CI was clean.

@jessemapel
Copy link
Contributor

Still needs a changelog entry and then this can be merged

@jessemapel jessemapel merged commit 06ac6de into DOI-USGS:dev May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISIS capability to work with Kaguya MI L3C5 data
2 participants