Phocube Slope and Normal Calculations #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemapel
reviewed
Aug 23, 2021
| @@ -319,6 +319,13 @@ xsi:noNamespaceSchemaLocation= | |||
| <change name="Kaitlyn Lee" date="2020-03-15"> | |||
| Converted application and tests for Gtest conversion. | |||
| </change> | |||
| <change name="Jesse Maple" date="2020-08-12"> | |||
| Added initial slope and slope azimuth computation to phocube. | |||
| </change> | |||
There was a problem hiding this comment.
I would axe my old change entry as it was never released independent of this one.
| and placed in a band in the output cube. The output cube labels will | ||
| contain "Slope" in the BandBin group, in band sequence of the output | ||
| file. The slope is in degrees with 0 degrees being perfectly flat and | ||
| 90 degrees being sheer vertical. |
There was a problem hiding this comment.
I would add a note that the slope is measured relative to a sphere and not a more complex datum like the gravity model.
| If this parameter is true, the local normal will be computed for | ||
| every pixel and placed in three bands (X, Y, Z) in the output cube. | ||
| The output cube labels will contain three "Local Normal (coord)" keywords | ||
| in the BandBin group, in band sequence of the output file. |
There was a problem hiding this comment.
Add a note that the X, Y, and Z values are in the body fixed reference frame. Also, add something about the local normal being computed from the shapemodel.
| If this parameter is true, the ellipsoid normal will be computed for | ||
| every pixel and placed in three bands (X, Y, Z) in the output cube. | ||
| The output cube labels will contain three "Ellipsoid Normal (coord)" | ||
| keywords in the BandBin group, in band sequence of the output file. |
There was a problem hiding this comment.
Same reference frame comment as local normal, except indicate that this is computed from the triaxial ellipsoid.
|
This also needs an "Added" entry in the Changelog. |
jessemapel
approved these changes
Aug 24, 2021
acpaquette
added a commit
to acpaquette/ISIS3
that referenced
this pull request
Sep 8, 2021
* First pass at slope in phocube * Added slope and azimuth cals to phocube.cpp * Added local normal and ellipsoid normal back plan calculations to phocube * Force pulled upstream new phocube main.cpp * Removed unused includes and moved a few lines around * Fixed up the includes one more time * Updated phocube docs based on PR feedback * Added changelog entry Co-authored-by: Jesse Mapel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses this branch as a basis
Adds new slope and surface normal calculations to phocube
Description
Adds three new options to phocube:
Related Issue
Closes #3645
Motivation and Context
2021 Q4 Sprint
How Has This Been Tested?
Not currently tested
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: