Fixed jigsaw observation mode

[jessemapel]

Description

Fixed a bug introduced in #4537 that caused observation mode in jigsaw to fail for framing images.

The IsisBundleObservation::initializeExteriorOrientation function was only being called within the else block of BundleObservationVector::addNew. This caused the orientation polynomials to only be setup properly when new observations are created. If an image is added to an existing observation, its orientation polynomials are not initialized. This PR moves the call outside of the if/else block so that the orientation polynomials are always initialized for ISIS observations.

Related Issue

Fixes #4686

Motivation and Context

The changes to add CSM support moved a call to initialize the position and pointing polynomial functions in jigsaw. This resulted in the initialization only happening for the first image in each observation when solving in observation mode. This caused an error when the parameter updates were copied from the first image to subsequent images in the each observation.

How Has This Been Tested?

I tested with a TGO CaSSIS data set. I generated a simple network using seedgrid and then added the images to it. This resulted in a network that is "perfect" and should bundle with extremely small corrections. With the correction, the network now bundles. Without the correction, the network fails at the end of the first iteration.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation change (update to the documentation; no code change)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read and agree to abide by the Code of Conduct
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have added myself to the .zenodo.json document.
• I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.