Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New push frame stitch application #4936

Merged
merged 5 commits into from
May 2, 2022

Conversation

jessemapel
Copy link
Contributor

Description

Adds a new application for stitching push frame images back together.

Related Issue

resolves #4924

Motivation and Context

We need this application for processing push frame imagery such as LRO WAC outside of ISIS. This will allow us to ingest the images into ISIS and do processing such as radiometric calibration and then export a single image with all of the image data in it. It will also allow us to flip the frame so that adjacent ground points are adjacent in the image and we can use matchers without fear of ending up on frame boundaries.

How Has This Been Tested?

Tested on an LRO WAC UV and VIS image set. There is also extensive automated testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

CHANGELOG.md Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.cpp Outdated Show resolved Hide resolved
isis/src/base/apps/framestitch/framestitch.xml Outdated Show resolved Hide resolved
isis/src/base/objs/ProcessByBrick/ProcessByBrick.cpp Outdated Show resolved Hide resolved
@jessemapel
Copy link
Contributor Author

Updated the docs, re-worked the error handling in the automatic frame height computations, and replaced all instances of frame size with frame height to be more clear.

Copy link
Contributor

@oleg-alexandrov oleg-alexandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further comments. Whenever the other reviewer approves this can be pulled in.

@jessemapel jessemapel merged commit 76f0fc6 into DOI-USGS:dev May 2, 2022
@jessemapel jessemapel mentioned this pull request May 2, 2022
13 tasks
amystamile-usgs pushed a commit to amystamile-usgs/ISIS3 that referenced this pull request May 4, 2022
* Added new framestitch app

* Added changelog entry

* Code updates

* Fixed comment, removed dep tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add application to stitch LRO WAC even and odd images together
3 participants