-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New push frame stitch application #4936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the docs, re-worked the error handling in the automatic frame height computations, and replaced all instances of frame size with frame height to be more clear. |
oleg-alexandrov
previously approved these changes
Apr 29, 2022
oleg-alexandrov
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no further comments. Whenever the other reviewer approves this can be pulled in.
AustinSanders
approved these changes
Apr 29, 2022
13 tasks
amystamile-usgs
pushed a commit
to amystamile-usgs/ISIS3
that referenced
this pull request
May 4, 2022
* Added new framestitch app * Added changelog entry * Code updates * Fixed comment, removed dep tags
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new application for stitching push frame images back together.
Related Issue
resolves #4924
Motivation and Context
We need this application for processing push frame imagery such as LRO WAC outside of ISIS. This will allow us to ingest the images into ISIS and do processing such as radiometric calibration and then export a single image with all of the image data in it. It will also allow us to flip the frame so that adjacent ground points are adjacent in the image and we can use matchers without fear of ending up on frame boundaries.
How Has This Been Tested?
Tested on an LRO WAC UV and VIS image set. There is also extensive automated testing.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: