Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CSMinit to pull body rotations #5071

Closed
wants to merge 3 commits into from

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Nov 10, 2022

Allows csminit to pull body rotations from ISDs that contain the body_rotation keyword

Description

Uses some ISIS SpiceRotation object functionality to pull the body_rotation key from an ISD (if it exists) and adds it to the cube as a BodyRotation table similar to spiceinit. This allows the CSMCamera to access other elements of the ISIS camera model that need access to the body rotaiton.

Related Issue

Ground based sensor work (See USGSCSM IAA Proposal)
Closes #5069
Closes #5057

How Has This Been Validated?

Validated through both hand testing and new gtest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just one more check for non JSON ISDs

isis/src/base/apps/csminit/csminit.cpp Outdated Show resolved Hide resolved
@acpaquette acpaquette marked this pull request as draft December 2, 2022 21:44
@acpaquette
Copy link
Collaborator Author

Closing in favor of #5072

@acpaquette acpaquette closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to get the body rotation when working with CSM data that contains an ALE ISD.
2 participants