feature updates for tgocassisstitch #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
@antonhibl Apologies for taking some time to get to this. Looks like it could use a fix for the changelog conflicts. The commit history here is also very messy. If we could do a |
acpaquette
reviewed
May 8, 2023
acpaquette
reviewed
May 30, 2023
acpaquette
previously requested changes
Aug 11, 2023
|
@acpaquette latest commits should have addressed the issues with dashes and I have tested locally to ensure they pass |
antonhibl
commented
Aug 16, 2023
added suffix and prefix capabilities in tgocassisstitch
addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or
suffix option when stitching frames together, just use OUTPUTSUFFIX instead
of OUTPUTPREFIX to use it.
minor fixes
typo
more typos
close to done, one error left
need to figure out a replacement for ui.IsOptionSet as that is not actually
a function. I need another way to test CLLI args.
final fixes to implement ui changes
fixed
now employs a boolean flag to decide if the name parsed with out is a suffix
or prefix, it defaults to a prefix.
adding some tests to confirm output runs as expected.
…bility
it also maintains original value names so older scripts and pipelines will
retain functionality.
adds another optional arg, cubename
lets the user specify an optional cubename parameter which replaces the
timestamp style naming for the output stitched cube. If the parameter is not
given it defaults to the timestamp style naming convention for retaining
existing functionality.
removed debugging code added changelog notes to xml for tgocassisstitch
added cubename argument logic typo in else statement
removed faulty/old tests based on makefiles fixed single and multi frame tests for tgocassisstitch remaining tests fixed, one on EFS to check with jenkins. removed debug lines updated to remove nil randomly appearing in tests modified first stitch test to use fallback naming behaviour.
…nches removing redundant lines from 8.0 release addresses prefix and filename convention topical issues
added details to changelog small typo in link
…bility
it also maintains original value names so older scripts and pipelines will
retain functionality.
changelog fixes removed typo
acpaquette
reviewed
Aug 22, 2023
github-actions
bot
added
enhancement
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addresses #5125, this allows the user to optionally use either the prefix or
suffix option when stitching frames together, just use OUTPUTSUFFIX instead
of OUTPUTPREFIX to use it.
Related Issue
#5125
How Has This Been Validated?
Tested locally and works by passing in either a OUTPUTSUFFIX or OUTPUT PREFIX.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: