Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission Specific PCK loading Fix #5335

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Nov 13, 2023

Description

Due to the ISIS data area being restructed, we now have pcks for most missions. Many missions pck data comes from the base area as most missions use the same PCK files. Because of this, we were having to copy PCK kernel db files into each mission. This change should fix that issue but still allow for missions that actually have specific PCKs and kernel dbs that need to be loaded.

Related Issue

#5280

How Has This Been Validated?

This will be validated through Jenkins Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@Kelvinrr Kelvinrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Kelvinrr Kelvinrr merged commit 6764514 into DOI-USGS:dev Nov 13, 2023
@github-actions github-actions bot added bug Something isn't working internal Astrogeology Science Center internal issues labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Astrogeology Science Center internal issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants