Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTiff Reading and Writing #5618

Open
wants to merge 50 commits into
base: dev
Choose a base branch
from
Open

GTiff Reading and Writing #5618

wants to merge 50 commits into from

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Sep 23, 2024 •
edited
Loading

Description

Adds support for GDAL GeoTiff reading and writing

Related Issue

IAA

How Has This Been Validated?

Added tests and validated by comparing to the same processes applied to cubes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@acpaquette acpaquette added the breaking API breaking change label Sep 23, 2024
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@Kelvinrr Kelvinrr self-assigned this Nov 18, 2024
@amystamile-usgs
Copy link
Contributor

A bunch of dependency conflicts in the build:

https://us-west-2.codebuild.aws.amazon.com/project/eyJlbmNyeXB0ZWREYXRhIjoiNDJNZ2MxbHFKTkwxV1RyQUxJekdJY3FIanNqU29rMHB4Nk1YUzk4REIrZUZDeEtEaW9HQlZ1dTZOSHpML2VUTGVDekYydmVFcU9sUHJKN20wQzd1Q0UzSzJscnB0MElDb1M3Ti9GTlJYR1RuMWJTV3V1SkJTa3NoYmc9PSIsIml2UGFyYW1ldGVyU3BlYyI6IjF3U2NTSGlDcEtCc29YVnEiLCJtYXRlcmlhbFNldFNlcmlhbCI6MX0%3D/build/56bd5e27-cce6-410a-b455-3f43a40b8e87

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

1 similar comment
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

2 similar comments
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Kelvinrr and others added 19 commits December 10, 2024 11:03
@Kelvinrr @acpaquette
replaced custom min/max with std::max/std::min
e2e946a
@Kelvinrr @acpaquette
left a gdal reference in
4fbdb2e
@acpaquette
Initial changes for a GdalIoHandler and creating an external DN cube
55b6a6d
@Kelvinrr @acpaquette
added write + tests
7faadbe
@acpaquette
Initial move away two flags on the cube to using the LabelAttachment …
71fadbf 
…to define label state
@acpaquette
Addressed PR feedback
4582ff2
@acpaquette
Added external gdal support to cube
6b45531
@acpaquette
Changed Tiff type to GTiff
c026c13
@acpaquette
Renamed imageIoHandler to ImageIoHandler
b8e14af
@acpaquette
Added pixeltype to gdaliohandler constructor
0d41bfd
@acpaquette
Added gdal pixel type translation and missing special pixels for vari…
a6d157a 
…ous ISIS pixel types
@acpaquette
Small fixes to get things working
fc8e4e8
@acpaquette
Removed prints and added -1s back to read and write
04dd5f6
@acpaquette
Changed gdal reads to use the raw buffer and correctly apply the ISIS…
0da457b 
… pixel type
@acpaquette
Added initial pixel conversions and tests for writing
d124b0f
@acpaquette
Final tests for pixel type reading and writing
0f75950
@acpaquette
Added tiff fixtures
09b5c8d
@acpaquette
Transfered pixel type to gdal handler in cube
9e080b6
@acpaquette
Silenced unsued return warning
61c4217
@acpaquette
Fixed boolean comparisons against enum
24029ea
@acpaquette
Initial stab at fixing the buffer copy
ea06217
@acpaquette
Adds msk file writting for tiffs
cb2abb3
@acpaquette
Added boundary check for buffers
3a92ae0
@acpaquette
Added fixture function to write a M x N x O tiff
3a610fb
@acpaquette
Reverted commented out Index access function Exceptions
4467612
@acpaquette
Default tiff DNs to the noDataValue
9963208
@acpaquette
Cleaned up buffer boundary handling for reads and writes
5c247b3
@acpaquette
Added gdal io tests for reading outside of the image
6820edc
@acpaquette
Updated shadow functional tests
656477f
@acpaquette
Properly handled pointers for mac and linux
56d0150
@acpaquette
Removed commented out line
14081bb
@acpaquette
Addressed OS dependent shadow failures
ea92118
@acpaquette
Removed read contraints on ecubes
aa82731
@acpaquette
Moved CubeIoHandler getters into public space
0ed2884
@acpaquette
Moved CubeIoHandler getters into public space
84afea7
@acpaquette
Made getDataFile protected
abe4f1a
@acpaquette
Made realDataFileName public on cube
bfd4cd0
@acpaquette
Added new cube tests as gtests
21185c1
@acpaquette
Added CubeBsqHandlerTests
f644dc7
@acpaquette
Removed old Cube unittests
bb5177f
@acpaquette
Removed cube truth
a8b3204
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5618".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kelvinrr Kelvinrr

Labels
breaking API breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acpaquette @amystamile-usgs @Kelvinrr