-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Distance unit tests #585
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,294 @@ | ||
#include "Distance.h" | ||
#include "Displacement.h" | ||
#include "IException.h" | ||
#include "SpecialPixel.h" | ||
|
||
#include <gtest/gtest.h> | ||
|
||
using namespace Isis; | ||
|
||
TEST(DistanceTests, DefaultConstructor) { | ||
Distance dist; | ||
EXPECT_EQ(dist.meters(), Null); | ||
EXPECT_EQ(dist.kilometers(), Null); | ||
EXPECT_EQ(dist.pixels(), Null); | ||
EXPECT_EQ(dist.solarRadii(), Null); | ||
} | ||
|
||
|
||
TEST(DistanceTests, MetersConstructor) { | ||
Distance dist(1500500, Distance::Meters); | ||
EXPECT_EQ(dist.meters(), 1500500); | ||
EXPECT_EQ(dist.kilometers(), 1500.5); | ||
EXPECT_DOUBLE_EQ(dist.solarRadii(), 1500500 / 6.9599e8); | ||
EXPECT_EQ(dist.pixels(1), 1500500); | ||
} | ||
|
||
|
||
TEST(DistanceTests, KilometersConstructor) { | ||
Distance dist(1500.5, Distance::Kilometers); | ||
EXPECT_EQ(dist.kilometers(), 1500.5); | ||
EXPECT_EQ(dist.meters(), 1500500); | ||
EXPECT_DOUBLE_EQ(dist.solarRadii(), 1500500 / 6.9599e8); | ||
EXPECT_EQ(dist.pixels(1), 1500500); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SolarRadiiConstructor) { | ||
Distance dist(1, Distance::SolarRadii); | ||
EXPECT_EQ(dist.solarRadii(), 1); | ||
EXPECT_DOUBLE_EQ(dist.meters(), 6.9599e8); | ||
EXPECT_DOUBLE_EQ(dist.kilometers(), 6.9599e5); | ||
EXPECT_DOUBLE_EQ(dist.pixels(1), 6.9599e8); | ||
} | ||
|
||
|
||
TEST(DistanceTests, PixelsConstructor) { | ||
Distance dist(1500500, Distance::Pixels); | ||
EXPECT_EQ(dist.pixels(1), 1500500); | ||
EXPECT_EQ(dist.meters(), 1500500); | ||
EXPECT_EQ(dist.kilometers(), 1500.5); | ||
EXPECT_DOUBLE_EQ(dist.solarRadii(), 1500500 / 6.9599e8); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See my other comment and use 1 solar radii = 6.9599e8 meters = 6.9599e5 km = 6.9599e8 pixels (with 1m per pixel) because all of the math will work out exactly. |
||
|
||
|
||
TEST(DistanceTests, PixelsPerMeterConstructor) { | ||
Distance dist(1500500, 2); | ||
EXPECT_EQ(dist.pixels(2), 1500500); | ||
EXPECT_EQ(dist.meters(), 750250); | ||
EXPECT_EQ(dist.kilometers(), 750.25); | ||
EXPECT_DOUBLE_EQ(dist.solarRadii(), 750250 / 6.9599e8); | ||
} | ||
|
||
|
||
TEST(DistanceTests, CopyConstructor) { | ||
Distance origDist(1500.5, Distance::Meters); | ||
Distance copiedDist(origDist); | ||
ASSERT_EQ(copiedDist.meters(), 1500.5); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SetMeters) { | ||
Distance dist; | ||
dist.setMeters(1500500); | ||
ASSERT_EQ(dist.meters(), 1500500); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SetKilometers) { | ||
Distance dist; | ||
dist.setKilometers(1500500); | ||
ASSERT_EQ(dist.kilometers(), 1500500); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SetSolarRadii) { | ||
Distance dist; | ||
dist.setSolarRadii(1); | ||
ASSERT_EQ(dist.solarRadii(), 1); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SetPixels) { | ||
Distance dist; | ||
dist.setPixels(1500500, 2); | ||
ASSERT_EQ(dist.pixels(2), 1500500); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SetNegativeDistance) { | ||
try { | ||
Distance dist; | ||
dist.setMeters(-1); | ||
FAIL() << "Expected error message: Negative distances are not supported"; | ||
} | ||
catch(IException &e) { | ||
EXPECT_TRUE(e.toString().contains("Negative distances are not supported")) | ||
<< e.toString().toStdString(); | ||
} | ||
catch(...) { | ||
FAIL() << "Expected error message: Negative distances are not supported"; | ||
} | ||
} | ||
|
||
|
||
TEST(DistanceTests, ToString) { | ||
Distance dist(1500500, Distance::Meters); | ||
ASSERT_EQ(dist.toString(), "1500500.0 meters"); | ||
} | ||
|
||
|
||
TEST(DistanceTests, IsValidTrue) { | ||
Distance dist(1500500, Distance::Meters); | ||
ASSERT_TRUE(dist.isValid()); | ||
} | ||
|
||
|
||
TEST(DistanceTests, IsValidFalse) { | ||
Distance dist; | ||
ASSERT_FALSE(dist.isValid()); | ||
} | ||
|
||
|
||
TEST(DistanceTests, GreaterThanDifferent) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
EXPECT_TRUE(dist2 > dist1); | ||
EXPECT_FALSE(dist1 > dist2); | ||
} | ||
|
||
|
||
TEST(DistanceTests, GreaterThanEqual) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(10, Distance::Meters); | ||
EXPECT_FALSE(dist2 > dist1); | ||
EXPECT_FALSE(dist1 > dist2); | ||
} | ||
|
||
|
||
TEST(DistanceTests, GreaterThanNull) { | ||
try { | ||
bool value = Distance() > Distance(); | ||
ASSERT_TRUE(value); // Added this line so we do not get an unused comparison build warning. | ||
FAIL() << "Expected error message: Distance has not been initialized"; | ||
} | ||
catch(IException &e) { | ||
EXPECT_TRUE(e.toString().contains("Distance has not been initialized")) | ||
<< e.toString().toStdString(); | ||
} | ||
catch(...) { | ||
FAIL() << "Expected error message: Distance has not been initialized"; | ||
} | ||
} | ||
|
||
|
||
TEST(DistanceTests, LessThanDifferent) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
EXPECT_TRUE(dist1 < dist2); | ||
EXPECT_FALSE(dist2 < dist1); | ||
} | ||
|
||
|
||
TEST(DistanceTests, LessThanEqual) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(10, Distance::Meters); | ||
EXPECT_FALSE(dist1 < dist2); | ||
EXPECT_FALSE(dist2 < dist1); | ||
} | ||
|
||
|
||
TEST(DistanceTests, LessThanNull) { | ||
try { | ||
bool value = Distance() < Distance(); | ||
ASSERT_TRUE(value); // Added this line so we do not get an unused comparison build warning. | ||
FAIL() << "Expected error message: Distance has not been initialized"; | ||
} | ||
catch(IException &e) { | ||
EXPECT_TRUE(e.toString().contains("Distance has not been initialized")) | ||
<< e.toString().toStdString(); | ||
} | ||
catch(...) { | ||
FAIL() << "Expected error message: Distance has not been initialized"; | ||
} | ||
} | ||
|
||
|
||
TEST(DistanceTests, AssignDistance) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
dist1 = dist2; | ||
ASSERT_EQ(dist1.meters(), 20); | ||
} | ||
|
||
|
||
TEST(DistanceTests, Add) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
Distance sum = dist1 + dist2; | ||
ASSERT_EQ(sum.meters(), 30); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SubtractPositive) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
Displacement difference = dist2 - dist1; | ||
ASSERT_EQ(difference.meters(), 10); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SubtractNegative) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
Displacement difference = dist1 - dist2; | ||
ASSERT_EQ(difference.meters(), -10); | ||
} | ||
|
||
|
||
TEST(DistanceTests, DivideDistance) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
ASSERT_EQ(dist2 / dist1, 2); | ||
} | ||
|
||
|
||
TEST(DistanceTests, DivideDouble) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance quotient = dist1 / 2; | ||
ASSERT_EQ(quotient.meters(), 5); | ||
} | ||
|
||
|
||
TEST(DistanceTests, Multiply) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance product = dist1 * 2; | ||
ASSERT_EQ(product.meters(), 20); | ||
} | ||
|
||
|
||
TEST(DistanceTests, AddAssign) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(20, Distance::Meters); | ||
dist1 += dist2; | ||
ASSERT_EQ(dist1.meters(), 30); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SubtractAssignPositive) { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(30, Distance::Meters); | ||
dist2 -= dist1; | ||
ASSERT_EQ(dist2.meters(), 20); | ||
} | ||
|
||
|
||
TEST(DistanceTests, SubtractAssignNegative) { | ||
try { | ||
Distance dist1(10, Distance::Meters); | ||
Distance dist2(30, Distance::Meters); | ||
dist1 -= dist2; | ||
FAIL() << "Expected error message: Negative distances are not supported"; | ||
} | ||
catch(IException &e) { | ||
EXPECT_TRUE(e.toString().contains("Negative distances are not supported")) | ||
<< e.toString().toStdString(); | ||
} | ||
catch(...) { | ||
FAIL() << "Expected error message: Negative distances are not supported"; | ||
} | ||
} | ||
|
||
|
||
TEST(DistanceTests, DivideAssign) { | ||
Distance dist(10, Distance::Meters); | ||
dist /= 2; | ||
ASSERT_EQ(dist.meters(), 5); | ||
} | ||
|
||
|
||
TEST(DistanceTests, MultiplyAssign) { | ||
Distance dist(10, Distance::Meters); | ||
dist *= 2; | ||
ASSERT_EQ(dist.meters(), 20); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if using parameters would make things nicer here. My only idea would be to use a Qlist of QLists where each QList element is made up of Distance::<unit_type> and every value the original distance gets converted to in all units. Each test has the conversions in different orders, so each test would need a different ordered list.