Modified GameEventListeners to include AddComponent #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modified SOArchitecture_Utility to include new constants for [AddComponent] menu structure for library and event listeners (currently only component type in library). * Modified code generation template to include [AddComponent] setup. * Modified all closed GameEventListener types to include [AddComponent] attribute with consistent menu names as used elsewhere for asset creation (case for menu item matches type name case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to add a small quality of life improvement by organizing the game event listener types into a more easily searchable menu when using
[AddComponent]on a GameObject inspector. It also updates the template for game event listeners to include the[AddComponent]attribute so future classes can automatically gain the benefit of this change.Testing
I would create a
GameObjectin the scene and try navigating the add component menu to ensure that all game event listener types are present and that the menu item name for each one is consistent for casing/spelling with that same type used in other menus such as for Variables or Events.There will also likely be a small conflict with #58 as both PRs modify this template, but should be easy to resolve.
Changes
Modified GameEventListeners for AddComponent