Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal default type parameters #6

Closed
wants to merge 1 commit into from
Closed

Fix illegal default type parameters #6

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link

Not sure if this crate is abandoned or not, but it's going to be broken by an upcoming bugfix in rustc. This PR removes some default type parameters on impls that are not currently permitted by the language.
See rust-lang/rust#36887 and rust-lang/rust#36894 for more details.

@DanielKeep
Copy link
Owner

Just to clarify: are you intending to address the CI failures in this PR? The macro and match errors are, I assume, unrelated.

@petrochenkov
Copy link
Author

Just to clarify: are you intending to address the CI failures in this PR?

Hmm, probably not (sorry). I'm just going through the list of regressions from crater and fix what is trivially fixable. Supporting Rust 1.3-1.5 seems to require some non-trivial actions.
Then just consider this a notification that this crate doesn't work on nightly 😄

@bluss
Copy link

bluss commented Nov 11, 2016

@petrochenkov That was the interesting thing that type parameter defaults in impls actually had effect in early Rust. I won't say they worked because their effect is different in-crate and cross-crate, but anyway 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants