-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature vehicle hitpoints revert #1514
Open
Enfield-303
wants to merge
17
commits into
master
Choose a base branch
from
feature-vehicle-hitpoints-revert
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to sort out the hitpoints
removing hamfisted deletions in vehicle code, tanks now have their traverse (side to side) and pitch (up and down) hitpoints back as well as the optics.
fixed some jank, jacksons origin is messed up, also changed NHP_GunPitch to green so its easier to differenciate between pitch and traverse
doin tha shermanz
bout 3/4 done now
su76, 152 and t60
revert complete
all tanks have hitpoints
why was this a thing in the first place
must have neglected to do this one, panzer 3 N hitpoints now line up
-Increase of ammo rack size on the german tanks -Added a bustle ammo rack to the is2 and tiger 2 German tanks had incredibly small ammo racks obviously for "balance reasons" #detheelinization, German tank ammo racks now increased in size to better fit their shell size. the STUH42 had an ammo rack size of a pea for example Tiger 2 and IS2 had an ammo rack in the bustle of their turret, added a hitpoint there to simulate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All vehicle now have individual hit points for traverse, gun elevation and optics, as well as this, minor changes to the existing hit points like the Tiger 2s ammo boxes being too small, and jagdtiger being too small.
-Hit-points reverted
-NHP_GunPitch now shows up as blue instead of gold (easier to differentiate)
-Minor tweaks to some of the hit-points
-All tanks have NHP_GunOptics allowing their optics to be damaged by penetrating shots to the direct point
-All tanks have NHP_Traverse and NHP_GunPitch allowing penetrating hits to damage their traverse and elevation
-German Tank hitpoints increased in size for continuity, increase to match their allied counterparts
-IS2 and King tiger now have an ammo rack in their bustle (turret)