Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit messages sent to the text chat to nearby players only #1615

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LordDz
Copy link
Collaborator

@LordDz LordDz commented Jun 15, 2023

Voice commands from the menu are currently sent to all players in the team, this limits the effectiviness of the commands.
It also spams the text chat if someone feels like spamming 'Sniper!'

I feel like it would be much nicer if voice chat command text messages were proximity based as well.
The ATTACK, DEFEND, UNDERATTACK and HELPAT commands will still be sent to the chat regardless of distance.

Messages like "Sniper!" "Grenade!" "Go Go Go!" "Enemy AT Soldier!" will have more meaning when you see them in the chat.¨

BEFORE
01
02

NOW
01b
02b

@LordDz
Copy link
Collaborator Author

LordDz commented Jun 15, 2023

I would suggest we try this on a beta test, on a close infantry map as well as advance maps.
Just to get the feel of it.

@cmbasnett cmbasnett self-requested a review June 16, 2023 02:18
@cmbasnett
Copy link
Member

Make sure that the naming conventions are all in line with the style guide (CamelCase, not camelCase).

@cmbasnett
Copy link
Member

I tested it out locally, 180 seems too far. 100 meters should be fine. Sorry this took so long to get to!

@LordDz LordDz marked this pull request as draft November 27, 2023 11:22
@LordDz LordDz marked this pull request as ready for review February 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants