Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running in docker #547

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Support running in docker #547

merged 4 commits into from
Feb 9, 2022

Conversation

aldafu
Copy link
Collaborator

@aldafu aldafu commented Jan 20, 2022

Add support to run entire stack in docker, draft PR

Use ./build.sh to locally build your docker image with all dependencies.

Create and run container from repository root directory, e.g.: docker run -d --name dc-tester -p 80:80 -v pwd:/var/www/html dash-if-conformance.

@aldafu aldafu requested a review from Phencys January 20, 2022 14:20
@aldafu
Copy link
Collaborator Author

aldafu commented Jan 20, 2022

@Phencys as discussed today. Do you possibly have suggestions for improvement?

@dsilhavy dsilhavy self-requested a review January 25, 2022 07:56
@dsilhavy dsilhavy added the Enhancement New feature or request label Jan 25, 2022
@Phencys
Copy link
Collaborator

Phencys commented Jan 27, 2022

Looks good to me so far. We will probably need to update this with newer versions etc. as we go, but this should serve as a good starting point.

@aldafu aldafu marked this pull request as ready for review February 2, 2022 16:47
@dsilhavy dsilhavy merged commit a844b4a into master Feb 9, 2022
@dsilhavy dsilhavy deleted the docker branch February 9, 2022 08:21
@dsilhavy dsilhavy mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants