Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono repo #548

Merged
merged 533 commits into from
Mar 4, 2022
Merged

Mono repo #548

merged 533 commits into from
Mar 4, 2022

Conversation

Phencys
Copy link
Collaborator

@Phencys Phencys commented Feb 17, 2022

This pull request contains:

  • The edits to merge all code into a single repository (i.e. remove all submodules)
  • A preliminary CLI implementation

The basic command line is as follows:

Utils/Process_cli.php <url> [options]

With url the URL of a stream, and options can be - at this time - one or more of:
DASH - Common dash mpd checks
DASH-IOP - DASH-IF Interoperability checks
DASH-IOP-LL - DASH-IF Low Latency checks

The script outputs JSON in a custom format to stdout, the format itself is preliminary and might change during the next couple of weeks, depending on what we find.

eceozturk and others added 30 commits February 5, 2019 15:01
Footer adjustment enabled also when treeinitiation
Splice constraint file information fix for ui
Splice constraints files added to ui
multiperiod processing enabled
 changes to MS1 unit tests after multiperiod update
 changes to unit tests of WAVE programs
bug fix for the multi-period UI
some minor changes to spelling etc
Few text changes for mbt-bw calculate page
Adding doc on cta wave conformance checklist
SRD patch code added to DASH mpd validator
Remove old sequence number check
@dsilhavy dsilhavy requested review from aldafu and dsilhavy February 17, 2022 13:00
@aldafu
Copy link
Collaborator

aldafu commented Feb 23, 2022

Had to address a couple points to get this going:

  • working directory has to be ./Utils, otherwise imports will fail and function will be undefined
  • Conformance-Frontend/temp/ needs to be created, so temporary file can be created/removed in there
  • use php7.4 when running with docker image/Ubuntu, since there is no php7 command there

Then I was able to test this by building a new docker image and running it like e.g.:

docker run --rm -w="/var/www/html/Utils" --entrypoint="" dash-if-conformance php7.4 ./Process_cli.php https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd DASH

This overwrites the original apache webserver entrypoint and runs the CLI impl instead.

I didn't notice a difference in the JSON output with regards to running differents tests i.e. ´DASH´ vs DASH-IOP or DASH-IOP-LL. Is that expected? If so, I'd go ahead and merge this with the hints from above added to README.md.

@Phencys
Copy link
Collaborator Author

Phencys commented Mar 2, 2022

I have addded some new commits, @aldafu can you recheck?
Main items;

  • Extra checks for HbbTV/DVB
  • Switch to php7.4 in the CLI script in order to be compatible with the docker image.
  • CLI now has 'normal' parsing, use -h to see all current options.

@aldafu
Copy link
Collaborator

aldafu commented Mar 2, 2022

lgtm @Phencys, runs much more stable.

Couple of questions/things I noticed

  • Are the default tests always done? Talking about Xlink resolving, MPD validation and Schematron validation as shown on web interface
  • Overall verdict seems to be null when module tests are successful, ie PASS (tested with https://media.axprod.net/TestVectors/Cmaf/clear_1080p_h264/manifest.mpd)
  • Do all additional tests run yet? JSON output for e.g. -w or -c returned with an empty entries property in the JSON

@Phencys
Copy link
Collaborator Author

Phencys commented Mar 4, 2022

Resolved the verdict remark, additional tests will be added to the framework over time.

@Phencys Phencys merged commit bba54c7 into development Mar 4, 2022
@Phencys Phencys deleted the mono-repo branch March 4, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.