Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor progress #585

Merged
merged 16 commits into from
Jun 8, 2022
Merged

Feature/refactor progress #585

merged 16 commits into from
Jun 8, 2022

Conversation

Phencys
Copy link
Collaborator

@Phencys Phencys commented May 25, 2022

Incremental progress update on the refactoring process.

  • Restores functionality of the repo pre-refactor
  • Extra checks for HbbTV/DVB, DASH IOP and DASH IOP LowLatency.
  • Initial unit test for the log util and work in progress for framework.

@rbouqueau
Copy link
Collaborator

@aldafu It seems like the linter checks no file. Is it expected?

https://github.com/Dash-Industry-Forum/DASH-IF-Conformance/runs/6586748535?check_suite_focus=true :

022-05-25 06:14:14 [INFO]   ---------------------------------
2022-05-25 06:14:14 [INFO]   ------ File list to check: ------
2022-05-25 06:14:14 [INFO]   ---------------------------------
2022-05-25 06:14:15 [INFO]   ----------------------------------------------
2022-05-25 06:14:15 [INFO]   Successfully gathered list of files...
2022-05-25 06:14:18 [INFO]   ----------------------------------------------
2022-05-25 06:14:18 [INFO]   ----------------------------------------------
2022-05-25 06:14:18 [INFO]   The script has completed
2022-05-25 06:14:18 [INFO]   ----------------------------------------------
2022-05-25 06:14:18 [INFO]   ----------------------------------------------
2022-05-25 06:14:18 [NOTICE]   All file(s) linted successfully with no errors detected
2022-05-25 06:14:18 [INFO]   ----------------------------------------------

@aldafu
Copy link
Collaborator

aldafu commented Jun 8, 2022

@aldafu It seems like the linter checks no file. Is it expected?

Not expected. The checkout task is checking out ref b3d31b8. A ref that doesn't seem to be part of this PR. In fact that ref doesn't seem to be anywhere. Could be the linter than gets confused and doesn't know what ref to compare against and thus fails to detect changed files.

Let's see if future PRs have a similar ref issue.

@aldafu
Copy link
Collaborator

aldafu commented Jun 8, 2022

PR changes seem fine. The web interface seems to deliver the same results as on master, lgtm

@aldafu aldafu merged commit 11c309f into development Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants