-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor progress #585
Conversation
@aldafu It seems like the linter checks no file. Is it expected?
|
Not expected. The checkout task is checking out ref b3d31b8. A ref that doesn't seem to be part of this PR. In fact that ref doesn't seem to be anywhere. Could be the linter than gets confused and doesn't know what ref to compare against and thus fails to detect changed files. Let's see if future PRs have a similar ref issue. |
PR changes seem fine. The web interface seems to deliver the same results as on master, lgtm |
Incremental progress update on the refactoring process.