Feature/add dvb dash 2017 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though I believe this is valid schematron, I get warnings when trying to compile this with create_val_schema.sh. Investigating. |
|
The code now compiles with create_val_schema.sh. I tested on all the example mpd files and the results are essentially identical except for a changed diagnostic message when the the profile string does not validate. |
Parametrize the check by building a structure of supported profiles
wschidol
force-pushed
the
feature/add-dvb-dash-2017
branch
from
25331dc to
97d8da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the code base already contained DVB-DASH 2017 profile tests, the profile string itself was not recognized. This PR fixes this and "legalizes"
urn:dvb:dash:profile:dvb-dash:2017. Note that this PR also brings in #589 so it makes sense to approve that first.It can be debated whether this fixes a bug or adds a feature. I opted for the latter and called this a feature but it could go either way.