Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/stderr #631

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Fix/stderr #631

merged 4 commits into from
Feb 6, 2023

Conversation

dsilhavy
Copy link
Contributor

This is supposed to address #613

  • stderr.txt is copied to the Representation subdirectories
  • HEALTH module does no longer include MPD duration checks which causes test interruption if failing
  • Output of stderr.txt is stored in the resulting JSON as a new entry:
SEGMENT_VALIDATION": {
      "": {
        "test": [
          {
            "spec": "Segment Validation",
            "section": "Segment Validation",
            "test": "std error output",
            "messages": [
              "..\/src\/ValidateAtoms.cpp : 3999 : colr atom of type nclx found, the software does not handle colr atoms of this type. \n..\/src\/ValidateAtomList.cpp : 2339 : WARNING: In moov-1:udta-1 - unknown\/unexpected atom 'meta'\nAccording to DASH-IF IOP Section 3.2.8 @bandwidth of the Representation (300000 bps) is set too high given the @minimumBufferTime (2 s), the minimum @bandwidth value required to conform is 296978 bps.\n"
            ],
            "state": "FAIL"
          }
        ],
        "verdict": "FAIL"
      },
      "verdict": "FAIL"
    }

Copy link
Collaborator

@Phencys Phencys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the logic for the error messages a bit, as not every line of output has to emit a FAIL level message on the stream.

@dsilhavy dsilhavy merged commit dbf3877 into development Feb 6, 2023
@dsilhavy dsilhavy deleted the fix/stderr branch March 9, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants