Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/validation issues #654

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Fixes/validation issues #654

merged 9 commits into from
Apr 18, 2023

Conversation

Phencys
Copy link
Collaborator

@Phencys Phencys commented Apr 17, 2023

Fixes for:

  • Media profile in WAVE
  • Media profile propagation
  • There was a issue with the check for section 7.3.2.3 where we checked for "no errors" in a variable named error, leading to the wrong verdict
  • Quality of life improvement to the wording considering stderr output
  • Quality of life improvement where ALL test messages now get prepended with a state symbol, making it easier to find fail messages in the interface.

dsilhavy and others added 9 commits April 14, 2023 10:18
@dsilhavy
Add missing assignment of $period_timing_info global variable. Also f…
3bf2cf5 
…ix addressing of the attributes of the resulting associative array.
@dsilhavy
getMediaProfile is not returning an array but a string. Fix a bug tha…
5afd810 
…t lead to the string being cut and tests to fail as a result
@dsilhavy
Fix WAVE CMFHD Baseline Program Shall contain a sequence of one or mo…
4da85f1 
…re CMAF Presentations conforming to CMAF CMFHD profile test
@Phencys
Check for 'no errors' instead of incorrect previous check
9a218bc
@Phencys
More verbose FPS output
74015b7
@Phencys
rint message when it is relevant only
ece5862
@Phencys
Store presentationprofile instead of trying to recalculate it
a38ea06 
# Conflicts:
#	CTAWAVE/impl/checkCMFHDBaselineConstraints.php
@Phencys
Quality of life: add pass/warn/fail symbol on each test line
5331210
@Phencys
Quality of life: Changed wording of segment validation error log
04a5872
@Phencys Phencys requested a review from dsilhavy April 17, 2023 09:59
@dsilhavy dsilhavy added this to the v2.2.1 milestone Apr 18, 2023
@dsilhavy dsilhavy merged commit ba3f4cc into development Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsilhavy dsilhavy dsilhavy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Phencys @dsilhavy