Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.6 VideoModel changes #986

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

LloydW93
Copy link
Member

@LloydW93 LloydW93 commented Jan 7, 2016

This PR reintroduces changes in the VideoModel that were not present in 1.5.1.

@LloydW93
Copy link
Member Author

There are a few parts to these changes:

  • stalledStreams had two different ways of tracking each stalled stream, in both list and object form. We've removed the use of the object form (stalledStreams.audio, stalledStreams.video) in favour of the list form, and also added checks to prevent the same stream being pushed in as stalled twice.
  • setSource as per discussions at the time, will cause the user agent to error due to an unsupported source if something falsey is passed in. This is currently done as part of reset (see [2.0] reset() has weird behaviour #974), which does make the line useless, which could be a little confusing.
  • previousPlaybackRate enables clients to set a custom playbackRate on the media element (e.g. 0.5 or 2) and not have this reset on rebuffering.
  • The playing/waiting events are to enable clients to see more natural events from the media elements. In our use case, our UI listens to the playing/waiting events on the media element to show a rebuffering indicator. This enables us to use the same events from the same object when dash.js pauses playback rebuffering.

dsparacio pushed a commit that referenced this pull request Jan 14, 2016
Add 1.6 VideoModel changes
@dsparacio dsparacio merged commit f10c9c8 into Dash-Industry-Forum:development Jan 14, 2016
@LloydW93 LloydW93 deleted the 20-videomodel branch January 27, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants