Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering & pagination issues in analytics package #4351

Closed
jpaten opened this issue Jan 24, 2025 · 0 comments · Fixed by #4352
Closed

Fix filtering & pagination issues in analytics package #4351

jpaten opened this issue Jan 24, 2025 · 0 comments · Fixed by #4352
Assignees
@jpaten
Labels
canary Done by the Clever Canary team

Comments

@jpaten
Copy link
Contributor

jpaten commented Jan 24, 2025 •
edited
Loading

Issue

  • Results for Outbound Links are missing many responses on HCA
  • GA responses are recurring a maximum of 1,000 results

Proposed Solution

  • Remove results filtering in sheets-elements.py, specifically anything that relies upon remove_matches elements in fields.py
  • Add dimension_filter calls in the arguments to get_data_df to replace this filtering
  • Change references of rowsCount to rowCount in api.py to fix pagination
@jpaten jpaten self-assigned this Jan 24, 2025
@github-actions github-actions bot added canary Done by the Clever Canary team labels Jan 24, 2025
jpaten added a commit that referenced this issue Jan 24, 2025
@jpaten
fix: renamed rowsCount to rowCount (#4351)
1aec654
jpaten added a commit that referenced this issue Jan 24, 2025
@jpaten
fix: switched ga result filtering from results to dimension filters (#…
372145c 
…4351)
jpaten added a commit that referenced this issue Jan 24, 2025
@jpaten
chore: bumped analytics package version (#4351)
9bbc850
jpaten added a commit that referenced this issue Jan 24, 2025
@jpaten
chore: updated analytics package docstrings (#4351)
5e6c0b9
@jpaten jpaten mentioned this issue Jan 24, 2025
Merged
@jpaten jpaten linked a pull request Jan 24, 2025 that will close this issue
Jonah/4351 analytics package issues #4352
Merged
@jpaten jpaten mentioned this issue Jan 24, 2025
Closed
hunterckx added a commit that referenced this issue Jan 25, 2025
@hunterckx
chore: remove test csv outputs (#4351)
a8208c2
hunterckx added a commit that referenced this issue Jan 25, 2025
@jpaten @hunterckx
fix: analytics package issues (#4352)
e0ce2c7 
* fix: renamed rowsCount to rowCount (#4351)

* fix: switched ga result filtering from results to dimension filters (#4351)

* chore: bumped analytics package version (#4351)

* chore: updated analytics package docstrings (#4351)

* chore: remove test csv outputs (#4351)

---------

Co-authored-by: hunterckx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpaten jpaten

Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jonah/4351 analytics package issues DataBiosphere/data-browser
1 participant
@jpaten