Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonah/4351 analytics package issues #4352

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Jan 24, 2025

Ticket

Closes #4351 .

Reviewers

Closes #4351

Changes

  • Changed rowsCount to rowCount in api.py to fix pagination
  • Removed remove_matches arguments and fields in fields.py and sheets_elements.py
  • Added dimension_filters in relevant get_flat_data_df calls in sheets_elements.py to replace remove_matches

Definition of Done (from ticket)

  • Remove results filtering in sheets-elements.py, specifically anything that relies upon remove_matches elements in fields.py
  • Add dimension_filter calls in the arguments to get_data_df to replace this filtering
  • Change references of rowsCount to rowCount in api.py to fix pagination

QA steps (optional)

  • Generated an example sheet and validated results against built in web reports and Query Explorer

@jpaten jpaten requested a review from hunterckx January 24, 2025 23:48
@jpaten jpaten linked an issue Jan 24, 2025 that may be closed by this pull request
@github-actions github-actions bot added the canary Done by the Clever Canary team label Jan 24, 2025
Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpaten!

@hunterckx hunterckx merged commit e0ce2c7 into main Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filtering & pagination issues in analytics package
2 participants