Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move contents of explorer to top level (#4230) #4242

Merged
merged 14 commits into from
Nov 9, 2024

Conversation

hunterckx
Copy link
Contributor

@hunterckx hunterckx commented Nov 8, 2024

Notes:

  • I wasn't really sure what do with the scripts directory that was already at the top level; I've renamed it to meta-scripts but I'm not sure if that's the best name -- This is now deleted
  • A few files that were edited as well as moved didn't register as renames in the change list:
    • explorer/.eslintignore
    • explorer/.gitignore (this one registered as an edit of the existing top-level gitignore)
    • scripts/update-archive-previews.js
    • scripts/update-sitemap.js

@github-actions github-actions bot added the canary Done by the Clever Canary team label Nov 8, 2024
@hunterckx hunterckx force-pushed the hunter/4230-explorer-contents-to-root branch from 83a55d4 to 2737847 Compare November 8, 2024 20:38
@NoopDog
Copy link
Collaborator

NoopDog commented Nov 8, 2024

@hunterckx meta-scripts can be deleted. It's obsolete.

.gitlab/fragments/explorer/build.yaml Outdated Show resolved Hide resolved
@hunterckx hunterckx dismissed hannes-ucsc’s stale review November 9, 2024 04:01

Suggested change was committed

@NoopDog NoopDog merged commit c433541 into main Nov 9, 2024
4 checks passed
@NoopDog NoopDog deleted the hunter/4230-explorer-contents-to-root branch November 9, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants